Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 TinaCMS Editing - Company Pages #1875

Merged
merged 1 commit into from
Dec 12, 2023
Merged

🐛 TinaCMS Editing - Company Pages #1875

merged 1 commit into from
Dec 12, 2023

Conversation

Harry-Ross
Copy link
Contributor

@Harry-Ross Harry-Ross commented Dec 12, 2023 •
edited
Loading

  • Fixed issue where Company pages could not be edited by adding a glob pattern to exclude documents in the company folder that aren't company page
  • Made company index a single page collection

image
Figure: Example of glob pattern usage

@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-1875.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 95
Performance 33
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1875.azurewebsites.net

amankumarrr
amankumarrr approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@amankumarrr amankumarrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Harry-Ross Harry-Ross merged commit f460822 into main Dec 12, 2023
10 checks passed
@Harry-Ross Harry-Ross deleted the 1869-fix-clients-editing branch December 12, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amankumarrr amankumarrr amankumarrr approved these changes

@bradystroud bradystroud Awaiting requested review from bradystroud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛Tina CMS - Client Page is not editable
2 participants
@Harry-Ross @amankumarrr