Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 Live page | Fix red-coloured text #1836

Merged
merged 10 commits into from
Dec 7, 2023
Merged

Conversation

jeoffreyfischer
Copy link
Member

Changed the feature to turn the text colour to red.
Before: bold text was turned into red colour.
After: html and css commands can be used to change the text colour.

website-PR-008a
Figure: The user can change the text colour using html and css

@jeoffreyfischer jeoffreyfischer self-assigned this Dec 5, 2023
Copy link
Contributor

@Harry-Ross Harry-Ross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✈️

Copy link
Contributor

github-actions bot commented Dec 5, 2023

Deployed changes to https://app-sswwebsite-9eb3-pr-1836.azurewebsites.net

Copy link
Contributor

github-actions bot commented Dec 5, 2023

PageSpeed Insights

Category Score
Accessibility 96
Best practices 95
Performance 27
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1836.azurewebsites.net

@Harry-Ross Harry-Ross changed the title Live page | Fix red-coloured text 💄 Live page | Fix red-coloured text Dec 6, 2023
components/live/header.tsx Outdated Show resolved Hide resolved
components/live/header.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Dec 6, 2023

Deployed changes to https://app-sswwebsite-9eb3-pr-1836.azurewebsites.net

Copy link
Contributor

github-actions bot commented Dec 6, 2023

PageSpeed Insights

Category Score
Accessibility 96
Best practices 91
Performance 28.000000000000004
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1836.azurewebsites.net

@jeoffreyfischer jeoffreyfischer merged commit ffa285c into main Dec 7, 2023
10 checks passed
@jeoffreyfischer jeoffreyfischer deleted the 1831-fix-red-text-feature branch December 7, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💄 Live page - Fix red-coloured text feature
2 participants