Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Migrate the testimonials page #1401

Merged
merged 27 commits into from
Oct 19, 2023
Merged

✨Migrate the testimonials page #1401

merged 27 commits into from
Oct 19, 2023

Conversation

KristenHu
Copy link
Contributor

@KristenHu KristenHu commented Sep 15, 2023 •
edited
Loading

  1. Migragte the testimonials page.
  2. Add the new testimonials component to show all testimonials cards on pages.
  3. Add buttons to hide this component and choose if internship testimonials cards should be shown.

image
image
image

@KristenHu KristenHu marked this pull request as ready for review September 25, 2023 01:30
Kristen added 2 commits September 25, 2023 09:39
Merge branch 'main' into testimonialsPage
a441c27 
# Conflicts:
#	.tina/__generated__/_graphql.json
#	.tina/__generated__/_schema.json
🐛Fix the eslint warning
c1b5441
@github-actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-1401.azurewebsites.net

@github-actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 91
Best practices 91
Performance 28.000000000000004
SEO 100

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1401.azurewebsites.net

@bradystroud bradystroud marked this pull request as draft September 26, 2023 03:40
@bradystroud
Copy link
Member

Hey @KristenHu

  • As per our conversation, see updated tasks in the PBI
  • Center the loading spinner and text

@github-actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-1401.azurewebsites.net

@github-actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 91
Best practices 91
Performance 27
SEO 100

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1401.azurewebsites.net

Kristen added 2 commits October 7, 2023 13:39
Merge branch 'main' into testimonialsPage
47ebc04 
# Conflicts:
#	.tina/__generated__/_graphql.json
#	.tina/__generated__/_schema.json
📃Migrate testimonial cards
816d8b8
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

Deployed changes to https://app-sswwebsite-9eb3-pr-1401.azurewebsites.net

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

PageSpeed Insights

Category Score
Accessibility 91
Best practices 91
Performance 28.000000000000004
SEO 100

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1401.azurewebsites.net

@KristenHu KristenHu marked this pull request as ready for review October 9, 2023 02:29
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Deployed changes to https://app-sswwebsite-9eb3-pr-1401.azurewebsites.net

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

PageSpeed Insights

Category Score
Accessibility 89
Best practices 95
Performance 56.00000000000001
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1401.azurewebsites.net

@KristenHu
Copy link
Contributor Author

KristenHu commented Oct 9, 2023 •
edited
Loading

Hey @KristenHu

  • As per our conversation, see updated tasks in the PBI
  • Center the loading spinner and text

Hey @bradystroud

  • As per our conversation, see updated tasks in the PBI

As per the conversation in Teams, the task of adjusting the style of testimonial cards can be discarded.

  • Center the loading spinner and text

Done.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

PageSpeed Insights

Category Score
Accessibility 94
Best practices 91
Performance 57.99999999999999
SEO 89

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1401.azurewebsites.net

amankumarrr
amankumarrr requested changes Oct 9, 2023
View reviewed changes
Copy link
Member

@amankumarrr amankumarrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Can we put testimonial's div into a container block? same like we are using for other blocks as it covers whole width of the screen

Kristen added 2 commits October 12, 2023 11:03
Merge branch 'main' into testimonialsPage
b971d3a 
# Conflicts:
#	.tina/__generated__/_graphql.json
#	.tina/__generated__/_lookup.json
#	.tina/__generated__/_schema.json
🐛Fix the display issue of testimonial cards
bd259d2
@github-actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-1401.azurewebsites.net

@github-actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 91
Performance 28.999999999999996
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1401.azurewebsites.net

Harry-Ross
Harry-Ross suggested changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@Harry-Ross Harry-Ross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Kristen, I've left some questions with this PR, we can go over these in a call later.

.tina/collections/company.tsx Outdated Show resolved Hide resolved
.tina/collections/company.tsx Outdated Show resolved Hide resolved
components/blocks/testimonialsList.tsx Outdated Show resolved Hide resolved
components/blocks/testimonialsList.tsx Outdated Show resolved Hide resolved
components/blocks/testimonialsList.tsx Outdated Show resolved Hide resolved
content/company/testimonials.mdx Outdated Show resolved Hide resolved
.tina/collections/company.tsx Outdated Show resolved Hide resolved
components/blocks/testimonialsList.tsx Show resolved Hide resolved
Kristen added 4 commits October 17, 2023 18:00
✨Extract testimonialCards as a public component
9aea503
Merge branch 'main' into testimonialsPage
9197538 
# Conflicts:
#	.tina/__generated__/_graphql.json
#	.tina/__generated__/_lookup.json
#	.tina/__generated__/_schema.json
Merge from main branch
2720fe2
🐛Fix the bug to show testimonials cards correctly
789a6b4
@github-actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-1401.azurewebsites.net

@github-actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 91
Performance 41
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1401.azurewebsites.net

Harry-Ross
Harry-Ross suggested changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@Harry-Ross Harry-Ross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my changes, looks good - thanks Kristen :)

.tina/collections/company.tsx Outdated Show resolved Hide resolved
.tina/collections/company.tsx Outdated Show resolved Hide resolved
components/blocks/testimonialsList.tsx Outdated Show resolved Hide resolved
content/company/testimonials.mdx Outdated Show resolved Hide resolved
content/consulting/access-database-upsizing.mdx Outdated Show resolved Hide resolved
KristenHu and others added 5 commits October 19, 2023 10:16
@KristenHu @Harry-Ross
⚡Remove useless code from company.tsx
6dba68e 
Co-authored-by: Harry Ross [SSW] <[email protected]>
@KristenHu @Harry-Ross
⚡Remove useless code from company.tsx
7254bad 
Co-authored-by: Harry Ross [SSW] <[email protected]>
⚡Remove useless props form testimonials.mdx
d5c9ebd
Merge branch 'main' into testimonialsPage
7a188fe 
# Conflicts:
#	.tina/__generated__/_graphql.json
#	.tina/__generated__/_schema.json
🐛Reverse the file
9897694
@github-actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-1401.azurewebsites.net

@github-actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 95
Performance 35
SEO 100

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1401.azurewebsites.net

Harry-Ross
Harry-Ross approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@Harry-Ross Harry-Ross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

amankumarrr
amankumarrr approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@amankumarrr amankumarrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-1401.azurewebsites.net

@KristenHu KristenHu merged commit 7cf9efe into main Oct 19, 2023
10 checks passed
@KristenHu KristenHu deleted the testimonialsPage branch October 19, 2023 03:38
@github-actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 95
Performance 32
SEO 100

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1401.azurewebsites.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Harry-Ross Harry-Ross Harry-Ross approved these changes

@amankumarrr amankumarrr amankumarrr approved these changes

@wicksipedia wicksipedia Awaiting requested review from wicksipedia

@bradystroud bradystroud Awaiting requested review from bradystroud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📄 Company Pages - Testimonials
4 participants
@KristenHu @bradystroud @Harry-Ross @amankumarrr