-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR - fixing the bug for the linked issue #1110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend adding comments to the action to make it clear why this is required.
From experience, it's usually hard to look back at scripts later on and work out why things were done the way they were done.
Deployed changes to https://app-sswwebsite-9eb3-pr-1110.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1110.azurewebsites.net |
Right, just added some comments |
Deployed changes to https://app-sswwebsite-9eb3-pr-1110.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1110.azurewebsites.net |
Fixes #1108
Description:
The issue was caused by the presence of double quotes and single quotes in the file paths of the newsletter's images. This discrepancy was identified during the investigation. By cleaning up the git differences, we were able to resolve the problem effectively and ensure that the file paths no longer contained any conflicting quotes, thereby resolving the issue.
Testing
Once, PR is merged, rebase this #1071 with main to test if it works.