Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR - fixing the bug for the linked issue #1110

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Conversation

amankumarrr
Copy link
Member

Fixes #1108

Description:
The issue was caused by the presence of double quotes and single quotes in the file paths of the newsletter's images. This discrepancy was identified during the investigation. By cleaning up the git differences, we were able to resolve the problem effectively and ensure that the file paths no longer contained any conflicting quotes, thereby resolving the issue.

Testing
Once, PR is merged, rebase this #1071 with main to test if it works.

Copy link
Member

@wicksipedia wicksipedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend adding comments to the action to make it clear why this is required.

From experience, it's usually hard to look back at scripts later on and work out why things were done the way they were done.

@github-actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-1110.azurewebsites.net

@github-actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 89
Best practices 92
Performance 27
SEO 100

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1110.azurewebsites.net

@amankumarrr
Copy link
Member Author

I'd recommend adding comments to the action to make it clear why this is required.

From experience, it's usually hard to look back at scripts later on and work out why things were done the way they were done.

Right, just added some comments

@amankumarrr amankumarrr enabled auto-merge (squash) July 24, 2023 07:03
@github-actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-1110.azurewebsites.net

@amankumarrr amankumarrr merged commit 0fca994 into main Jul 24, 2023
9 checks passed
@amankumarrr amankumarrr deleted the pr-link-issue-bad-string branch July 24, 2023 07:17
@github-actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 89
Best practices 92
Performance 28.000000000000004
SEO 100

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1110.azurewebsites.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 PR - Linked issue
2 participants