Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨♻️ Add /industry pages #1033

Merged
merged 15 commits into from
Jul 17, 2023
Merged

✨♻️ Add /industry pages #1033

merged 15 commits into from
Jul 17, 2023

Conversation

bradystroud
Copy link
Member

Add finance page

Fixes #1029

Affected routes:

  • /industry/finance
  • /industry/educational

Add done video, screenshots

@bradystroud bradystroud linked an issue Jul 14, 2023 that may be closed by this pull request
⚠️ Urgent - new webpage - finance #1029
Closed
Harry-Ross
Harry-Ross suggested changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@Harry-Ross Harry-Ross left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Now that you have made prose-industry in the Tailwind config, can you move these custom <p> and <h3> elements to there?

@bradystroud bradystroud marked this pull request as ready for review July 16, 2023 23:02
@github-actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-1033.azurewebsites.net

@github-actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 89
Best practices 83
Performance 36
SEO 100

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1033.azurewebsites.net

amankumarrr
amankumarrr approved these changes Jul 16, 2023
View reviewed changes
Copy link
Member

@amankumarrr amankumarrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bradystroud
Copy link
Member Author

bradystroud commented Jul 17, 2023 •
edited
Loading

Feedback as per my conversation with @sethdailyssw

  • Fix title to match the text
  • 'Finance Software Solutions' should be H1
  • 'Customised Technology Solutions' should be H2
  • 'Overview, How SSW can help, and How can SSW channel...' should be H3
  • Change Customised to Customized in the H2
  • photoshop the banner image to be SSW red (or close)
  • Add alt text to each image

@github-actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-1033.azurewebsites.net

@github-actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 89
Best practices 83
Performance 28.000000000000004
SEO 100

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1033.azurewebsites.net

@bradystroud bradystroud enabled auto-merge (squash) July 17, 2023 02:37
Harry-Ross
Harry-Ross approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@Harry-Ross Harry-Ross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🍳

@github-actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-1033.azurewebsites.net

@bradystroud bradystroud merged commit 6d404f0 into main Jul 17, 2023
9 checks passed
@bradystroud bradystroud deleted the 1029-new-page-finance branch July 17, 2023 02:52
@github-actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 89
Best practices 83
Performance 32
SEO 100

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1033.azurewebsites.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Harry-Ross Harry-Ross Harry-Ross approved these changes

@amankumarrr amankumarrr amankumarrr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

⚠️ Urgent - new webpage - finance
3 participants
@bradystroud @Harry-Ross @amankumarrr