Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to download silcam_database.zip from exampledata.py #329

Open
arsalanmstn opened this issue Oct 18, 2024 · 2 comments
Open

Unable to download silcam_database.zip from exampledata.py #329

arsalanmstn opened this issue Oct 18, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@arsalanmstn
Copy link
Contributor

The exampledata.get_classifier_database_from_pysilcam_blob(download_directory='./') does not download the silcam_dataset.zip. When running the function, it only returns download_directory.

@emlynjdavies emlynjdavies added the bug Something isn't working label Oct 19, 2024
@emlynjdavies
Copy link
Collaborator

sounds like a bug here.

If i do:

exampledata.get_classifier_database_from_pysilcam_blob('silcam_classification_database')

then I get a folder structure with tiff files in each of the classes in a directory called 'silcam_classification_database'

@nepstad
Copy link
Collaborator

nepstad commented Oct 21, 2024

The problem with this function is that it checks for existing folder (download_directory), and if it exists, it does nothing, just returning the name of the folder. Combined with the default option of download_directory='.', this creates the observed behavior.

Work-around: always specify a non-existing folder
Fix: Remove default value for "download_directory", or change it to something else, for instance a randomly generated name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants