Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WireCell Noise-Filtering Updates (Data + Simulation) #539

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

WireCell Noise-Filtering Updates (Data + Simulation) #539

wants to merge 12 commits into from
+236 −12

Conversation

lynnt20
Copy link
Contributor

@lynnt20 lynnt20 commented Oct 16, 2024 •
edited
Loading

Description

Update coherent noise-filtering and other bits for MC and data.

  • adjust coherent noise parameters (for signal protection)
  • update RC tail deconvolution time constant (from 1.1ms to 0.5ms), based on data
  • change number of expected ticks in data from 3415 -> 3427
  • add a main jsonnet for running noise-filtering only

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • [N/A] Linked any relevant issues under Developement
  • [N/A] Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • [N/A] Does this affect the standard workflow?

Link(s) to docdb describing changes (optional)

Noise filtering studies in docdb38535.

@lynnt20 lynnt20 added the tpc Time Projection Chamber label Oct 16, 2024
@lynnt20 lynnt20 self-assigned this Oct 16, 2024
@lynnt20 lynnt20 changed the title WireCell Noise-Filtering Updates (Data + MC) WireCell Noise-Filtering Updates (Data) Oct 31, 2024
@lynnt20 lynnt20 marked this pull request as ready for review October 31, 2024 18:44
@bear-is-asleep
Copy link
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v09_93_01 SBNSoftware/sbnanaobj@bug/coackley_ciCafv09_91_02

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

weihythu
weihythu reviewed Nov 1, 2024
View reviewed changes
Copy link
Contributor

@weihythu weihythu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • change RC time constant(s) in other jsonnet (simparams.jsonnet) to be consistent with NF RC constant

weihythu
weihythu approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@weihythu weihythu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lynnt20
Copy link
Contributor Author

lynnt20 commented Nov 4, 2024

trigger build LArSoft/lar*@LARSOFT_SUITE_v09_93_01 SBNSoftware/sbnanaobj@bug/coackley_ciCafv09_91_02

1 similar comment
@bear-is-asleep
Copy link
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v09_93_01 SBNSoftware/sbnanaobj@bug/coackley_ciCafv09_91_02

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@lynnt20 lynnt20 changed the title WireCell Noise-Filtering Updates (Data) WireCell Noise-Filtering Updates (Data + Simulation) Nov 7, 2024
@lynnt20 lynnt20 added data features for data processing detsim Detector simulation labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebelchio12 ebelchio12 ebelchio12 approved these changes

@weihythu weihythu weihythu approved these changes

Assignees

@lynnt20 lynnt20

Labels
data features for data processing detsim Detector simulation tpc Time Projection Chamber
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lynnt20 @bear-is-asleep @FNALbuild @weihythu @ebelchio12