Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrivilegesCLI add/remove output message #89

Open
Jaharmi opened this issue Jan 11, 2024 · 1 comment
Open

PrivilegesCLI add/remove output message #89

Jaharmi opened this issue Jan 11, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Jaharmi
Copy link

Jaharmi commented Jan 11, 2024

PrivilegesCLI’s output when the “add” or “remove” options are used is grammatically awkward in English:

  • “User X has now admin rights”
  • “User X has now standard user rights”

It should be:

  • “User X now has admin rights”
  • “User X now has standard user rights”

Or, it could also be the following. (This would be somewhat less-useful for parsing/matching against the output.)

  • “User X has admin rights now
  • “User X has standard user rights now

English arranges “now” differently in a sentence compared to German’s “jetzt.”

@mthielemann mthielemann self-assigned this Mar 6, 2024
@mthielemann mthielemann added the bug Something isn't working label Mar 6, 2024
@SAP SAP locked and limited conversation to collaborators Mar 12, 2024
@mthielemann
Copy link
Contributor

This will be fixed in Privileges 2.0.0, which will be available later this year.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants