Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript: Add documentation for service binding to destination API #1883

Merged
merged 5 commits into from
Aug 12, 2024

Conversation

shibeshduw
Copy link
Contributor

What Has Changed?

Added documentation for the 2 new public APIs which were added in v3.16.0 release:

  • getServiceBinding
  • transformServiceBindingToDestination

Closes SAP/cloud-sdk-backlog#1221

docs-js/features/connectivity/destination.mdx Outdated Show resolved Hide resolved
docs-js/features/connectivity/destination.mdx Outdated Show resolved Hide resolved
docs-js/features/connectivity/destination.mdx Outdated Show resolved Hide resolved
docs-js/features/connectivity/destination.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@KavithaSiva KavithaSiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. @marikaner could you take a look too? Is it important to mention from which version this functionality is available?

Copy link
Contributor

@marikaner marikaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks good to me, just details

docs-js/features/connectivity/destination.mdx Outdated Show resolved Hide resolved
docs-js/features/connectivity/destination.mdx Outdated Show resolved Hide resolved
docs-js/features/connectivity/destination.mdx Outdated Show resolved Hide resolved
docs-js/features/connectivity/destination.mdx Outdated Show resolved Hide resolved
docs-js/features/connectivity/destination.mdx Outdated Show resolved Hide resolved
@KavithaSiva KavithaSiva merged commit 3614c86 into main Aug 12, 2024
7 checks passed
@KavithaSiva KavithaSiva deleted the javascript/service-binding-to-dest branch August 12, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants