Extend Apache HttpClient 5 test assertions for actual headers #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # cloudplatform/connectivity-apache-httpclient5/src/test/java/com/sap/cloud/sdk/cloudplatform/connectivity/ApacheHttpClient5FactoryBuilderTest.java
newtork
added
please merge
MatKuhr
reviewed
Nov 12, 2024
| .extracting("httpClient", as(type(Configurable.class))) | ||
| .satisfies(client -> assertThat(client.getConfig().isProtocolUpgradeEnabled()).isFalse()); | ||
| @SneakyThrows | ||
| private TlsUpgradeAssertion withUpgradeHeader( |
There was a problem hiding this comment.
yeah this is a bit complicated, maybe you can try using a parameterized test or wiremock scenario instead?
There was a problem hiding this comment.
Yeah.... I wanted to avoid writing additional class definition. But maybe this code really is too much.
There was a problem hiding this comment.
Please find my proposal for parameterized test, not sure whether it's better...
#640
newtork
removed
please merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of asserting on Java objects and fields, let's check for actual headers being used.
Context