Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilized ServiceBinding classes #636

Merged
merged 6 commits into from
Nov 12, 2024
Merged

Stabilized ServiceBinding classes #636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5619fc0
Initial
a-d Nov 5, 2024
a651bc5
Add release note
a-d Nov 5, 2024
312eb85
Merge branch 'main' into stabilize/request-header
CharlesDuboisSAP Nov 11, 2024
f4d674a
Stabilized ServiceBinding classes
CharlesDuboisSAP Nov 11, 2024
1646ec6
Merge branch 'main' into stabilize/service-binding
CharlesDuboisSAP Nov 12, 2024
387ea02
Stabilized ServiceBinding classes in dwc and oauth modules
CharlesDuboisSAP Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ...ctivity/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/BtpServiceOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
import javax.annotation.Nonnull;
import javax.annotation.Nullable;

import com.google.common.annotations.Beta;
import com.sap.cloud.sdk.cloudplatform.connectivity.ServiceBindingDestinationOptions.OptionsEnhancer;

import lombok.AccessLevel;
Expand All @@ -23,7 +22,6 @@
*
* @since 4.20.0
*/
@Beta
public final class BtpServiceOptions
{
/**
Expand Down
2 changes: 0 additions & 2 deletions ...sap/cloud/sdk/cloudplatform/connectivity/DefaultServiceBindingDestinationLoaderChain.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@

import org.apache.commons.lang3.exception.ExceptionUtils;

import com.google.common.annotations.Beta;
import com.sap.cloud.environment.servicebinding.api.ServiceBinding;
import com.sap.cloud.sdk.cloudplatform.connectivity.exception.DestinationAccessException;
import com.sap.cloud.sdk.cloudplatform.connectivity.exception.DestinationNotFoundException;
Expand Down Expand Up @@ -42,7 +41,6 @@
* @since 4.16.0
*/
@Slf4j
@Beta
class DefaultServiceBindingDestinationLoaderChain implements ServiceBindingDestinationLoader
{
@Nonnull
Expand Down
3 changes: 0 additions & 3 deletions ...tivity/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/DestinationUtility.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@

import org.apache.commons.lang3.StringUtils;

import com.google.common.annotations.Beta;

import io.vavr.control.Option;
import lombok.extern.slf4j.Slf4j;

Expand All @@ -23,7 +21,6 @@
*
* @since 4.6.0
*/
@Beta
@Slf4j
public final class DestinationUtility
{
Expand Down
2 changes: 0 additions & 2 deletions .../main/java/com/sap/cloud/sdk/cloudplatform/connectivity/ErpDestinationHeaderProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

import javax.annotation.Nonnull;

import com.google.common.annotations.Beta;
import com.sap.cloud.sdk.cloudplatform.servlet.LocaleAccessor;

import lombok.extern.slf4j.Slf4j;
Expand All @@ -23,7 +22,6 @@
* @see DestinationProperty#DYNAMIC_SAP_LANGUAGE
* @since 4.16.0
*/
@Beta
@Slf4j
public class ErpDestinationHeaderProvider implements DestinationHeaderProvider
{
Expand Down
5 changes: 1 addition & 4 deletions ...m-connectivity/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/OnBehalfOf.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,11 @@

package com.sap.cloud.sdk.cloudplatform.connectivity;

import com.google.common.annotations.Beta;

/**
* Represents the behalf upon which an outbound request can be made.
*
* @since 4.10.0
*/
@Beta
public enum OnBehalfOf
{
/**
Expand All @@ -32,5 +29,5 @@ public enum OnBehalfOf
*
* @since 4.10.0
*/
NAMED_USER_CURRENT_TENANT;
NAMED_USER_CURRENT_TENANT
}
3 changes: 0 additions & 3 deletions .../src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/PrincipalPropagationMode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@

package com.sap.cloud.sdk.cloudplatform.connectivity;

import com.google.common.annotations.Beta;

import lombok.RequiredArgsConstructor;

/**
Expand All @@ -14,7 +12,6 @@
* @since 5.0.0
*/
@RequiredArgsConstructor
@Beta
public enum PrincipalPropagationMode
{
/**
Expand Down
2 changes: 0 additions & 2 deletions ...in/java/com/sap/cloud/sdk/cloudplatform/connectivity/ServiceBindingDestinationLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

import javax.annotation.Nonnull;

import com.google.common.annotations.Beta;
import com.sap.cloud.environment.servicebinding.api.ServiceBinding;
import com.sap.cloud.sdk.cloudplatform.connectivity.exception.DestinationAccessException;
import com.sap.cloud.sdk.cloudplatform.connectivity.exception.DestinationNotFoundException;
Expand All @@ -22,7 +21,6 @@
* @since 4.16.0
*/
@FunctionalInterface
@Beta
public interface ServiceBindingDestinationLoader
{
/**
Expand Down
2 changes: 0 additions & 2 deletions ...n/java/com/sap/cloud/sdk/cloudplatform/connectivity/ServiceBindingDestinationOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

import javax.annotation.Nonnull;

import com.google.common.annotations.Beta;
import com.sap.cloud.environment.servicebinding.api.DefaultServiceBindingAccessor;
import com.sap.cloud.environment.servicebinding.api.ServiceBinding;
import com.sap.cloud.environment.servicebinding.api.ServiceIdentifier;
Expand All @@ -30,7 +29,6 @@
*/
@RequiredArgsConstructor( access = AccessLevel.PRIVATE )
@Slf4j
@Beta
public final class ServiceBindingDestinationOptions
{
/**
Expand Down
2 changes: 0 additions & 2 deletions ...in/java/com/sap/cloud/sdk/cloudplatform/connectivity/MegacliteServiceBindingAccessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@

import javax.annotation.Nonnull;

import com.google.common.annotations.Beta;
import com.sap.cloud.environment.servicebinding.api.ServiceBinding;
import com.sap.cloud.environment.servicebinding.api.ServiceBindingAccessor;
import com.sap.cloud.environment.servicebinding.api.ServiceIdentifier;
Expand All @@ -30,7 +29,6 @@
*
* @since 4.17.0
*/
@Beta
@Slf4j
public class MegacliteServiceBindingAccessor implements ServiceBindingAccessor
{
Expand Down
6 changes: 2 additions & 4 deletions ...om/sap/cloud/sdk/cloudplatform/connectivity/MegacliteServiceBindingDestinationLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

import javax.annotation.Nonnull;

import com.google.common.annotations.Beta;
import com.sap.cloud.environment.servicebinding.api.ServiceBinding;
import com.sap.cloud.environment.servicebinding.api.ServiceIdentifier;
import com.sap.cloud.sdk.cloudplatform.connectivity.ServiceBindingDestinationOptions.Options;
Expand All @@ -29,7 +28,6 @@
* @see MegacliteServiceBindingAccessor
* @since 4.17.0
*/
@Beta
@Slf4j
public final class MegacliteServiceBindingDestinationLoader implements ServiceBindingDestinationLoader
{
Expand Down Expand Up @@ -147,8 +145,8 @@ MegacliteServiceBinding.MandateConfiguration getMandateConfigurationOrThrow(
private MegacliteServiceBinding getBindingOrThrow( @Nonnull final ServiceBindingDestinationOptions options )
{
final ServiceBinding serviceBinding = options.getServiceBinding();
if( serviceBinding instanceof MegacliteServiceBinding ) {
return (MegacliteServiceBinding) serviceBinding;
if( serviceBinding instanceof MegacliteServiceBinding megacliteServiceBinding ) {
return megacliteServiceBinding;
}
final String msg =
"Unable to transform the provided service binding for service '%s' into a Megaclite based destination. Expected the service binding to be of type '%s' but got a '%s' instead.";
Expand Down
2 changes: 0 additions & 2 deletions ...th/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/OAuth2PropertySupplier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

import javax.annotation.Nonnull;

import com.google.common.annotations.Beta;
import com.sap.cloud.security.config.ClientIdentity;

/**
Expand All @@ -17,7 +16,6 @@
*
* @since 4.20.0
*/
@Beta
public interface OAuth2PropertySupplier
{
/**
Expand Down
2 changes: 0 additions & 2 deletions ...a/com/sap/cloud/sdk/cloudplatform/connectivity/OAuth2ServiceBindingDestinationLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

import org.apache.http.HttpHeaders;

import com.google.common.annotations.Beta;
import com.sap.cloud.environment.servicebinding.api.ServiceIdentifier;
import com.sap.cloud.sdk.cloudplatform.connectivity.ServiceBindingDestinationOptions.Options;
import com.sap.cloud.sdk.cloudplatform.connectivity.exception.DestinationAccessException;
Expand All @@ -34,7 +33,6 @@
* @since 4.16.0
*/
@Slf4j
@Beta
public class OAuth2ServiceBindingDestinationLoader implements ServiceBindingDestinationLoader
{
@Nonnull
Expand Down
1 change: 1 addition & 0 deletions release_notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

- Stabilize experimental OData client API without changes.
- Stabilize RequestHeaderAccessor related API without changes.
- Stabilize ServiceBindingDestinationLoader related API without changes.

### 🐛 Fixed Issues

Expand Down
Loading