Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TLS/SSL version upgrade handling OPTIN for OnPremise #631

Merged
merged 10 commits into from
Nov 8, 2024
Merged

Make TLS/SSL version upgrade handling OPTIN for OnPremise #631

merged 10 commits into from
Nov 8, 2024

Conversation

newtork
Copy link
Contributor

@newtork newtork commented Nov 6, 2024 •
edited
Loading

Context

https://github.com/SAP/cloud-sdk-java-backlog/issues/463

  • Disable automatic upgrade when using proxy (e.g. when using OnPremise)
  • Add optional toggle to override the behavior and force on/off.

Fixed symptoms

  • Connecting to OnPremise via SAP Cloud Connector using latest Apache HttpClient 5
  • >> Upgrade: TLS/1.2
>> Connection: Upgrade

<< HTTP/1.1 403 Forbidden
<<
<< "Upgrade to protocols [TLS/1.2] denied for resource [...]

Definition of Done

@newtork newtork marked this pull request as draft November 6, 2024 12:51
@newtork newtork mentioned this pull request Nov 6, 2024
Open
12 tasks
@newtork newtork marked this pull request as ready for review November 8, 2024 09:57
@newtork newtork added please merge Request to merge a pull request please review Request to review a pull request labels Nov 8, 2024
MatKuhr
MatKuhr reviewed Nov 8, 2024
View reviewed changes
Copy link
Member

@MatKuhr MatKuhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

release_notes.md Outdated Show resolved Hide resolved
.../main/java/com/sap/cloud/sdk/cloudplatform/connectivity/DefaultApacheHttpClient5Factory.java Outdated Show resolved Hide resolved
newtork and others added 5 commits November 8, 2024 14:42
@newtork @MatKuhr
Update cloudplatform/connectivity-apache-httpclient5/src/main/java/co…
9d3397c 
…m/sap/cloud/sdk/cloudplatform/connectivity/DefaultApacheHttpClient5Factory.java

Co-authored-by: Matthias Kuhr <[email protected]>
@newtork @MatKuhr
Update release_notes.md
d9d3485 
Co-authored-by: Matthias Kuhr <[email protected]>
@a-d
Fix test
ea4a32c
@a-d
Merge branch 'httpclient5/tls-upgrade' of https://github.com/SAP/clou…
eb58af0 
…d-sdk-java into httpclient5/tls-upgrade
@newtork @a-d
Proper API to change TLS upgrade flag and store it on instance level,…
a782e8e 
… non-static (#634)

Co-authored-by: Alexander Dümont <[email protected]>
@MatKuhr MatKuhr enabled auto-merge (squash) November 8, 2024 14:57
@MatKuhr MatKuhr merged commit a07fb46 into main Nov 8, 2024
14 checks passed
@MatKuhr MatKuhr deleted the httpclient5/tls-upgrade branch November 8, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatKuhr MatKuhr MatKuhr approved these changes

Assignees
No one assigned
Labels
please merge Request to merge a pull request please review Request to review a pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@newtork @MatKuhr @a-d