Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add actor account support for 1.0.0 #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

garemoko
Copy link

Fixes #19

This is what it ends up looking like:

image

Or before you enter the values:
image

@garemoko
Copy link
Author

Note that I deliberately did not rename "agentValue" to "agentEmail" for two reasons:

  1. Backwards compatibility. TinCanViewer.js needs to work with systems that have used the code with their own html UI (like Watershed) and may not yet have made relevant changes to take advantage of the account functionality.

  2. This field could be used with openid and mboxsha1sum too, and in fact it would be a trivial (but out of scope of this PR) change to make that work.

@garemoko
Copy link
Author

Also note, regarding "else cuddling" - a lot of the existing code in TimCanViewer.js does cuddle elses so I followed that style.

agent = new TinCan.Agent(agentCfg);
} else if (agentValue !== null) {
agentCfg[agentProperty] = agentValue;
agent = new TinCan.Agent(agentCfg);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line ends up being duplicated to avoid overly complex if conditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant