Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sha2: use ARM intrinsics rather than ASM #571

Closed
tarcieri opened this issue Mar 12, 2024 · 2 comments
Closed

sha2: use ARM intrinsics rather than ASM #571

tarcieri opened this issue Mar 12, 2024 · 2 comments

Comments

@tarcieri
Copy link
Member

As of Rust 1.76, the SHA-256 NEON intrinsics are stable, but the SHA-512 ones are not. See tracking issue here: rust-lang/rust#117225

We currently use asm! for both algorithms to "emulate" the relevant unstable intrinsics.

It probably doesn't make sense to switch only SHA-256 to the intrinsics, which would necessitate what's currently an aggressive MSRV bump to 1.76, but wouldn't completely get rid of the asm!.

When the SHA-512 intrinsics have been stabilized and we're ready to bump MSRV, we can migrate both implementations.

@tarcieri
Copy link
Member Author

This PR stabilizes the SHA-512 intrinsics: rust-lang/stdarch#1552

@newpavlov
Copy link
Member

Done in #607

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants