ALSA: fix buffer size / period size configuration #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abique
force-pushed
the
alsa-period-cfg
branch
from
9879b3c
to
62324d5
Compare
With ALSA, the buffer size is `nperiod * period_size`. We want 2 periods ideally. The default is now set to 1024 samples which is a reasonable default, yet still too large for real-time audio. The default value now uses the same code path as custom values. Fixes RustAudio#913
abique
force-pushed
the
alsa-period-cfg
branch
from
62324d5
to
8d86b11
Compare
|
It is now a month that this PR is opened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With ALSA, the buffer size is
nperiod * period_size. We want 2 periods ideally.The default is now set to 1024 samples which is a reasonable default, yet still too large for real-time audio.
Also the default value uses the same code path as custom values.
Fixes #913
Depends on #915 for successful compilation.
Replaces #914