Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Make asynciterator asynciterable #89

Closed
jeswr opened this issue Sep 20, 2022 · 2 comments
Closed

Feat: Make asynciterator asynciterable #89

jeswr opened this issue Sep 20, 2022 · 2 comments
Labels
semver.minor
Milestone
v4-beta

Comments

@jeswr
Copy link
Collaborator

jeswr commented Sep 20, 2022

In particular this logic https://github.com/LDflex/LDflex-Comunica/blob/f01ece6fa8cee720061efd5ddd23ed82921555e4/src/ComunicaEngine.ts#L158-L215 should be implemented as the [Symbol.asyncIterator] method of AsyncIterator
@jacoscaz
Copy link
Collaborator

This would be very convenient, although we should also carefully measure differences in performance and highlight them in README.md as refactoring from one approach to the other is likely a non-trivial effort.

@rubensworks
Copy link
Collaborator

Related to #56

@RubenVerborgh RubenVerborgh added this to the v4-beta milestone Sep 21, 2022
@rubensworks rubensworks mentioned this issue Jan 12, 2023
Open
rubensworks added a commit to rubensworks/AsyncIterator that referenced this issue Jul 4, 2023
@rubensworks
Make iterators AsyncIterable, Closes RubenVerborgh#89
c330211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
semver.minor
Projects
None yet
Milestone
v4-beta
Development

No branches or pull requests
4 participants
@rubensworks @RubenVerborgh @jacoscaz @jeswr