Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on SciPy #64

Open
klane opened this issue Jul 22, 2021 · 0 comments
Open

Remove dependency on SciPy #64

klane opened this issue Jul 22, 2021 · 0 comments
Assignees
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Milestone

Comments

@klane
Copy link
Collaborator

klane commented Jul 22, 2021

SciPy is only used for some sparse matrix operations in utils/graph.py. These include:

  • scipy.sparse.coo_matrix
  • scipy.sparse.csr_matrix
  • scipy.sparse.diags
  • scipy.sparse.eye
  • scipy.sparse.identity (this just calls eye)
  • scipy.sparse.issparse
  • scipy.sparse.linalg.eigsh

If PyTorch has equivalent functionality in torch.sparse, then these should be ported over to PyTorch and SciPy should be removed as a dependency.

@klane klane added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Jul 22, 2021
@klane klane self-assigned this Jul 22, 2021
@klane klane added this to the Initial release milestone Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

No branches or pull requests

1 participant