Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Fix Username Highlighting Issue in Russian Language Mentions #33800

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

SinghaAnirban005
Copy link
Contributor

This PR addresses a bug where usernames mentioned with the @ symbol are not highlighted when the user’s language is set to Russian. This issue occurs in system messages, such as those generated by Rocket.Cat, and prevents proper highlighting of the @username mention in Russian.

Changes:

Adjusted the JSON file of Russian translations to render highlighted username
Tested the fix with both Russian and English language settings to confirm consistency.

Screenshots:

Before
image

After
image

Issue(s)

Closes #33793

Further comments

This fix ensures that users in Russian-speaking regions experience the same usability as other language settings, where mentions are correctly highlighted. Further testing might be beneficial to confirm no issues with other languages.

Copy link
Contributor

dionisio-bot bot commented Oct 26, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 26, 2024

⚠️ No Changeset found

Latest commit: 0df9807

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Username Highlight Not Working in Notification When User Language is Set to Russian
1 participant