Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: user highlights matching just part of words #33776

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Oct 24, 2024

Proposed changes (including videos or screenshots)

created some unit tests to illustrate what was the issue with the previous code
image

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 24, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 24, 2024

🦋 Changeset detected

Latest commit: 980fbfb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33776/
on branch gh-pages at 2024-10-24 22:29 UTC

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.56%. Comparing base (899e0a6) to head (980fbfb).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33776   +/-   ##
========================================
  Coverage    75.55%   75.56%           
========================================
  Files          492      493    +1     
  Lines        21558    21566    +8     
  Branches      5373     5374    +1     
========================================
+ Hits         16288    16296    +8     
  Misses        4630     4630           
  Partials       640      640           
Flag Coverage Δ
unit 75.56% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sampaiodiego sampaiodiego changed the title fix: user highlights fix: user highlights matching just part of words Oct 25, 2024
@sampaiodiego sampaiodiego marked this pull request as ready for review October 25, 2024 14:55
@sampaiodiego sampaiodiego requested a review from a team as a code owner October 25, 2024 14:55
ricardogarim
ricardogarim previously approved these changes Oct 25, 2024
}

return highlights.some((highlight: string) => {
const regexp = new RegExp(`\\b${escapeRegExp(highlight)}\\b`, 'i');
Copy link
Member

@matheusbsilva137 matheusbsilva137 Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will still make us highlight emojis (:highlight:), won't it? 🤔 I wonder if we should take the chance to fix this too (wdyt, do you consider them words too? I've already seem some complaints about this)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm.. good point.. let me create a few unit tests

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to not match emojis.. not the prettiest regex but that's the one I could come up with

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants