Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node picker: differentiate CURIE option from name resolver options #276

Open
Woozl opened this issue Mar 19, 2024 · 0 comments
Open

Node picker: differentiate CURIE option from name resolver options #276

Woozl opened this issue Mar 19, 2024 · 0 comments
Assignees

Comments

@Woozl
Copy link
Member

Woozl commented Mar 19, 2024

When typing text into the node picker, the current implementation adds an option to the dropdown with the literal text entered if it includes a colon :. This idea of this is to support inputing a CURIE directly into the box. This presents a problem if the node you're searching for contains a colon in its label. Relevant code:

if (searchTerm.includes(':')) { // user is typing a specific curie
newOptions.push({ name: searchTerm, ids: [searchTerm] });
}

See the following example. Note this is from the YOBOKOP UI/graph, so it may not show up in the ROBOKOP UI.

The very first option in the list will put the text H3K4me (chrIII:451-600) (the label/name of the yeast node) in as the CURIE in the TRAPI request. Where as the other options (the results from nameres) will show the label/name in the UI when clicked, but populate the actual CURIE/identifier in the TRAPI request.

The actual node desired is the third option in this list (notice it has the same text as the first option). When the third is clicked, it will put in the right CURIE (BinHisPTM:chrX(451-600);H3K36me2). If the first is clicked, no results will be returned because the name isn't a valid identifier

Screen.Recording.2024-03-19.at.2.27.59.PM.mov
@Woozl Woozl self-assigned this Mar 19, 2024
@Woozl Woozl changed the title Node picker: differentiate Node picker: differentiate CURIE option from name resolver options Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant