Revise RoboSuiteLauncher to launch FaceLogin instead of RoboTutor #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrated app pinning
JackMostow
approved these changes
May 17, 2021
|
add development branch to merge into instead |
JackMostow
approved these changes
May 23, 2021
There was a problem hiding this comment.
I'm approving these changes in the interest of moving forward, but I'd expect launching FaceLogin instead of RoboTutor to require changing only 2 lines -- one to change the name of the app to be launched, and one to change the version number of RoboSuiteLauncher, plus possibly a line or two to pin apps -- not 83 files! I gather that the 83 files are copied from the RoboTutor_2020 repo rather than imported from it. Can you revise the commit to do it that way instead? If not, please explain why. Copying code is dangerous because it creates the risk of updating one copy but not another.
JackMostow
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised RoboSuiteLauncher to launch FaceLogin instead of RoboTutor, added app pinning, util module, logging module, and config module.