Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relation Context in Discourse Context is not working #199

Open
mdroidian opened this issue Dec 15, 2023 · 2 comments
Open

Relation Context in Discourse Context is not working #199

mdroidian opened this issue Dec 15, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@mdroidian
Copy link
Collaborator

https://oasis-lab.gitbook.io/roamresearch-discourse-graph-extension/guides/exploring-your-discourse-graph/discourse-context#show-the-context-of-each-relation

image

Reported by Ekuboh in slack

@mdroidian mdroidian added the bug Something isn't working label Dec 15, 2023
@mdroidian
Copy link
Collaborator Author

The Context column via Discourse Context was commented out here #98, then removed fully here #123

It looks like this functionality was somewhat replaced in Query Drawer and Query Blocks via actions (where action:context:icon loads the full page).

But was the ExtraColumnRow for Discourse Context also supported somewhere else?

Discourse Context
image

I'm leaning towards "no" because it still exists in DiscourseContext.tsx but has no references to it.
@dvargas92495 thoughts?

image

const ExtraColumnRow = (r: Result) => {

@dvargas92495
Copy link
Collaborator

no it wasn't - I thought it would but that was the only use case and you're right as far as the modern way to go about this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

2 participants