New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code highlights don't work for all languages #10

Open

kvistgaard opened this issue Aug 19, 2023 · 1 comment

kvistgaard commented Aug 19, 2023

For Javascript, and CSS, it works fine, but not for Turtle:

Here's how it looks in Roam

And here's the same snippet in Presentation mode:

Interestingly, wth SPARQL, which is a variant of Turtle, everything is fine.

Contributor

mdroidian commented Aug 26, 2023

We use PrismJS, which looks like it doesn't support that code block.

We could either:

report this issue to PrismJS: https://github.com/PrismJS/prism/
create our own definitions: https://prismjs.com/extending.html#language-definitions
see if we can piggy back off Roam via: Replace Custom Presentation Renderer with new Roam API for Render Block #6

I'm leaning towards the last option, but I'm not sure when I'll be able to tackle that just yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment