Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to Geomorphic Units Layers #466

Closed
Jdgilby opened this issue Aug 6, 2024 · 8 comments
Closed

Changes to Geomorphic Units Layers #466

Jdgilby opened this issue Aug 6, 2024 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@Jdgilby
Copy link
Collaborator

Jdgilby commented Aug 6, 2024

@joewheaton Can you confirm I got this right before @KellyMWhitehead makes any changes.

I remember we decided to get rid of Tier 2( or potentially auto populate based on selection of tier 2.5)

New Attribute Will be 'Type' and options will be 'Pool', 'Riffle', 'Mid Channel Bar', Bank Attached Bar', 'Glide/Run', 'Pond', 'Rapid', 'Chute', and 'Cascade'

@Jdgilby Jdgilby added the enhancement New feature or request label Aug 6, 2024
@KellyMWhitehead
Copy link
Collaborator

Added new fields to Geomorphic Unit Extent and Geomorphic Unit (points) layers. Version 0.9

Did not remove tier 2 field until I get the go ahead.

@joewheaton
Copy link
Contributor

@Jdgilby close if you are satisfied, and reassign to @KellyMWhitehead if they need more work.

@philipbaileynar and @Jdgilby and I missed these in our roundup of 1.0 release tasks. I am assigning this to 1.0, if it is unrealistic, you can move this to 1.1.

@joewheaton joewheaton added this to the 1.0 - Public Release milestone Sep 13, 2024
@Jdgilby
Copy link
Collaborator Author

Jdgilby commented Sep 13, 2024

@joewheaton Do we still want Tier 2 or just go with 2.5?

@joewheaton
Copy link
Contributor

Go with both, but 2.5 is only mandatory

@Jdgilby
Copy link
Collaborator Author

Jdgilby commented Sep 16, 2024

@KellyMWhitehead Im not sure the of the form functionality the way they're currently set up. If its possible ideally we would want Type as the first dropdown and its mandatory (especially since symbology is based off this field). And Type 2 Tier would be optional.

@KellyMWhitehead
Copy link
Collaborator

I have moved the Type field to the top and specified it as mandatory, however I need to plumb the logic into this. I don't think that part will be ready by v1.0.

@Jdgilby
Copy link
Collaborator Author

Jdgilby commented Sep 16, 2024

@KellyMWhitehead Thats fine, we will have to do this for other layers as well anyways. As long as the symbology communicates for V1 we are fine.

@KellyMWhitehead
Copy link
Collaborator

Mandatory fields will be added in #499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants