From ee65e7712a767283611d92110bbdae855e22381c Mon Sep 17 00:00:00 2001 From: DivadNojnarg Date: Thu, 1 Aug 2024 20:41:27 +0200 Subject: [PATCH] fix CRAN NOTE + update news ... --- DESCRIPTION | 5 +++-- NEWS.md | 3 +++ R/dashboardSidebar.R | 4 ++-- cran-comments.md | 11 +++++++++++ man/sidebar.Rd | 4 ++-- 5 files changed, 21 insertions(+), 6 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index a398b579..284d50a9 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -30,10 +30,11 @@ Suggests: shinyjqui, knitr, rmarkdown, - jsonlite + jsonlite, + bslib URL: https://github.com/RinteRface/shinydashboardPlus, https://shinydashboardPlus.rinterface.com/ BugReports: https://github.com/RinteRface/shinydashboardPlus/issues Encoding: UTF-8 -RoxygenNote: 7.3.1 +RoxygenNote: 7.3.2 VignetteBuilder: knitr RdMacros: lifecycle diff --git a/NEWS.md b/NEWS.md index 3f0a78a7..2e8cf0ad 100644 --- a/NEWS.md +++ b/NEWS.md @@ -2,6 +2,9 @@ - Add shinylive to support the different demo apps. +## Minor change +- Fix NOTE in CRAN checks. + # shinydashboardPlus 2.0.4 ## Minor change diff --git a/R/dashboardSidebar.R b/R/dashboardSidebar.R index 76cb7903..76bdecea 100644 --- a/R/dashboardSidebar.R +++ b/R/dashboardSidebar.R @@ -1,7 +1,7 @@ #' Create a dashboard sidebar. #' -#' A dashboard sidebar typically contains a \code{\link{sidebarMenu}}, although -#' it may also contain a \code{\link{sidebarSearchForm}}, or other Shiny inputs. +#' A dashboard sidebar typically contains a \code{\link[shinydashboard]{sidebarMenu}}, although +#' it may also contain a \code{\link[shinydashboard]{sidebarSearchForm}}, or other Shiny inputs. #' #' @param ... Items to put in the sidebar. #' @param disable If \code{TRUE}, the sidebar will be disabled. diff --git a/cran-comments.md b/cran-comments.md index e679898e..a23e552e 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -8,3 +8,14 @@ - 0 error, 0 warnings, 0 Notes. ## Notes +- Fix NOTES in older release: + +Version: 2.0.4 +Check: Rd cross-references +Result: NOTE + Found the following Rd file(s) with Rd \link{} targets missing package + anchors: + sidebar.Rd: sidebarMenu, sidebarSearchForm + Please provide package anchors for all Rd \link{} targets not in the + package itself and the base packages. +Flavors: r-devel-linux-x86_64-debian-gcc, r-devel-windows-x86_64 diff --git a/man/sidebar.Rd b/man/sidebar.Rd index 7d6eb83e..420b366f 100644 --- a/man/sidebar.Rd +++ b/man/sidebar.Rd @@ -35,8 +35,8 @@ to TRUE.} \item{session}{Shiny session object.} } \description{ -A dashboard sidebar typically contains a \code{\link{sidebarMenu}}, although -it may also contain a \code{\link{sidebarSearchForm}}, or other Shiny inputs. +A dashboard sidebar typically contains a \code{\link[shinydashboard]{sidebarMenu}}, although +it may also contain a \code{\link[shinydashboard]{sidebarSearchForm}}, or other Shiny inputs. \link{updateSidebar} allows to toggle a \link{dashboardSidebar} on the client. }