From 2b76dc5ee1c6cef46f59d1e0ba7dd612f7e81ecd Mon Sep 17 00:00:00 2001
From: DivadNojnarg <dgranjon@ymail.com>
Date: Tue, 3 Sep 2024 20:03:00 +0200
Subject: [PATCH] update CRAN comments

---
 DESCRIPTION      |  2 +-
 NEWS.md          |  1 +
 R/tabs.R         |  6 +++---
 cran-comments.md | 12 ++++++++++--
 man/insertTab.Rd |  8 ++++----
 5 files changed, 19 insertions(+), 10 deletions(-)

diff --git a/DESCRIPTION b/DESCRIPTION
index dfaeb65c..d67e90e4 100644
--- a/DESCRIPTION
+++ b/DESCRIPTION
@@ -32,7 +32,7 @@ Suggests:
     DT, 
     thematic (>= 0.1.2)
 Encoding: UTF-8
-RoxygenNote: 7.2.3
+RoxygenNote: 7.3.2
 VignetteBuilder: knitr
 Collate: 
     'feedbacks.R'
diff --git a/NEWS.md b/NEWS.md
index fc75946a..0d8f2315 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -4,6 +4,7 @@
 
 ## Minor change
 - Update jquery-ui to 1.13.2. Thanks @biognosys-so.
+- Fix CRAN NOTES.
 
 # bs4Dash 2.3.3
 
diff --git a/R/tabs.R b/R/tabs.R
index a2a4cbc7..67e39ff9 100644
--- a/R/tabs.R
+++ b/R/tabs.R
@@ -261,11 +261,11 @@ tabsetPanel <- function(..., id = NULL, selected = NULL,
 
 
 
-#' Insert a \link{tabPanel} in a \link{tabsetPanel}
+#' Insert a \link[shiny]{tabPanel} in a \link{tabsetPanel}
 #'
 #' @param inputId  \link{tabsetPanel} id.
-#' @param tab \link{tabPanel} to insert.
-#' @param target \link{tabPanel} after of before which the new tab will be inserted.
+#' @param tab \link[shiny]{tabPanel} to insert.
+#' @param target \link[shiny]{tabPanel} after of before which the new tab will be inserted.
 #' @param position Insert before or after: \code{c("before", "after")}.
 #' @param select Whether to select the newly inserted tab. FALSE by default.
 #' @param session Shiny session object.
diff --git a/cran-comments.md b/cran-comments.md
index abe17c18..157bad12 100644
--- a/cran-comments.md
+++ b/cran-comments.md
@@ -9,5 +9,13 @@
 There were no ERRORs or WARNINGs or NOTEs.
 
 ## Note
-This release will fixe the NOTES on https://cran.r-project.org/web/checks/check_results_bs4Dash.html.
-Update: re-submissiom fixing issue with `omicsTools` reverse dependency.
\ No newline at end of file
+Fix a 3 NOTES:
+
+> Version: 2.3.3
+Check: Rd cross-references
+Result: NOTE 
+  Found the following Rd file(s) with Rd \link{} targets missing package
+  anchors:
+    insertTab.Rd: tabPanel
+  Please provide package anchors for all Rd \link{} targets not in the
+  package itself and the base packages.
\ No newline at end of file
diff --git a/man/insertTab.Rd b/man/insertTab.Rd
index f91a6f57..1ec5f748 100644
--- a/man/insertTab.Rd
+++ b/man/insertTab.Rd
@@ -2,7 +2,7 @@
 % Please edit documentation in R/tabs.R
 \name{insertTab}
 \alias{insertTab}
-\title{Insert a \link{tabPanel} in a \link{tabsetPanel}}
+\title{Insert a \link[shiny]{tabPanel} in a \link{tabsetPanel}}
 \usage{
 insertTab(
   inputId,
@@ -16,9 +16,9 @@ insertTab(
 \arguments{
 \item{inputId}{\link{tabsetPanel} id.}
 
-\item{tab}{\link{tabPanel} to insert.}
+\item{tab}{\link[shiny]{tabPanel} to insert.}
 
-\item{target}{\link{tabPanel} after of before which the new tab will be inserted.}
+\item{target}{\link[shiny]{tabPanel} after of before which the new tab will be inserted.}
 
 \item{position}{Insert before or after: \code{c("before", "after")}.}
 
@@ -27,7 +27,7 @@ insertTab(
 \item{session}{Shiny session object.}
 }
 \description{
-Insert a \link{tabPanel} in a \link{tabsetPanel}
+Insert a \link[shiny]{tabPanel} in a \link{tabsetPanel}
 }
 \examples{
 if (interactive()) {