Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No warning when not-existent stratas are used in the deposit #211

Open
FooterManDev opened this issue Aug 19, 2023 · 1 comment
Open

No warning when not-existent stratas are used in the deposit #211

FooterManDev opened this issue Aug 19, 2023 · 1 comment
Assignees
Labels
bug Something isn't working to be reviewed requires additional analysis

Comments

@FooterManDev
Copy link

Issue description

When creating an Emendatus Geode, the Geode will be air.
image

{
    "type": "emendatusenigmatica:geode_deposit",
    "dimension": "minecraft:overworld",
    "biomes": ["minecraft:ice_spikes"],
    "registryName": "silica_geode",
    "config": {
        "outerShellBlocks": [
            {"block": "minecraft:granite", "weight": 20},
            {"block": "minecraft:dirt", "weight": 5}
        ],
        "innerShellBlocks": [
            {"block": "minecraft:diorite", "weight": 30}
        ],
        "innerBlocks": [
            {"block": "emendatusenigmatica:silica_cluster_shard_block", "weight": 6},
            {"block": "emendatusenigmatica:budding_silica", "weight": 4}
        ],
        "clusters": [
            "emendatusenigmatica:small_silica_bud",
            "emendatusenigmatica:medium_silica_bud"
        ],
        "fillBlocks": [
            {"block": "minecraft:air", "weight": 10}
        ],
        "chance": 10,
        "rarity": "common",
        "crackChance": 0.25,
        "minYLevel": -60,
        "maxYLevel": 20,
        "generateSamples": false,
        "sampleBlocks": [],
        "fillerTypes": [
            "minecraft_stone",
            "minecraft_deepslate",
            "minecraft_diorite",
            "minecraft_andesite",
            "minecraft_tuff",
            "minecraft_granite"
        ]
    }
}

Steps to reproduce

Make a Geode.
Find where the Geode is set to generate.

Minecraft version

1.19.2 (Latest)

Forge version

43.2.21

Emendatus Enigmatica version

2.1.x (Latest)

Other relevant versions

No response

If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)

No response

@FooterManDev FooterManDev added bug Something isn't working to be reviewed requires additional analysis labels Aug 19, 2023
@Kanzaji
Copy link
Contributor

Kanzaji commented Sep 4, 2023

After a bit of investigation, it turned out the issue was missing stratas used in the FillerTypes 😅
Might be worth changing this to "No warning when not-existent stratas are used in the deposit"

Additional context:
Behaviour tested in EE 2.1.5 on Forge 43.2.3

@FooterManDev FooterManDev changed the title Broken Geodes No warning when not-existent stratas are used in the deposit Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working to be reviewed requires additional analysis
Projects
None yet
Development

No branches or pull requests

3 participants