Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes build failure with gcc-10 #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arielscarpinelli
Copy link

This is a cherry-pick from the commit in the original repo to fix this issue HaarigerHarald#33

which happens trying to install / update retropie_setup in an updated bullseye

@arielscarpinelli
Copy link
Author

@cmitu

@cmitu
Copy link

cmitu commented Aug 1, 2024

@arielscarpinelli thanks for sending this.
It looks ok, but I'm not sure if how it's still applicable to RetroPie, since omxiv works only with the legacy BRCM drivers, which were removed in RaspiOS Bullseye completely - that's why it's not fixed here.
Either way, I don't have any commit privileges here so I can't accept nor merge this request.

@arielscarpinelli
Copy link
Author

I did update my distro recently to bullseye and retropie to latest thru setup script. Maybe this tool is not needed anymore but is def being tried to be built, that's how I ended up with this change.
Is the splashscreen module deprecated? Because is still referencing this package.

BTW it is working fine in my pi, but idk if it is still using an old driver because I did a distro upgrade instead of fresh install?

@cmitu
Copy link

cmitu commented Aug 1, 2024

Is the splashscreen module deprecated? Because is still referencing this package.

No, it's not. It's not going to work as is with the Pi using KMS/DRM drivers - which is the default on new RaspiOS installations starting with Bullseye.

BTW it is working fine in my pi, but idk if it is still using an old driver because I did a distro upgrade instead of fresh install?

Yes, probably because of that - not a supported configuration by either the RaspiOS authors or RetroPie. Do note that Bullsye and also Bookworm have increased the needed space for the /boot partition (among a lot of other things) so in-place upgrades to Bookworm may fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants