Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #29 #30

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Fix for issue #29 #30

merged 2 commits into from
Feb 15, 2023

Conversation

andrew-bate-rai
Copy link
Contributor

This change fixes the Sunfire plugin configuration for Apache Arrow to allow tests to run. See issue #29 and this page for more information.

@andrew-bate-rai andrew-bate-rai requested review from bradlo and NRHelmi and removed request for bradlo December 2, 2022 17:42
@NRHelmi
Copy link
Contributor

NRHelmi commented Dec 9, 2022

we set an environment variable in the github workflow https://github.com/RelationalAI/rai-sdk-java/blob/main/.github/actions/test/action.yml#L54
I think it's also useful to have it as a argument to the test command, thanks @andrew-bate-rai

@torkins
Copy link
Collaborator

torkins commented Jan 26, 2023

@andrew-bate-rai any reason this is not yet merged? Can it be closed if no longer needed?

@andrew-bate-rai andrew-bate-rai merged commit e00a61f into main Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants