Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from react-native-snap-carousel to react-native-pager #13

Open
Redseb opened this issue Oct 21, 2020 · 8 comments
Open

Migrate from react-native-snap-carousel to react-native-pager #13

Redseb opened this issue Oct 21, 2020 · 8 comments
Assignees
Labels
refactor A clean up / refactor of the code

Comments

@Redseb
Copy link
Owner

Redseb commented Oct 21, 2020

(react-native-pager)[https://github.com/ajsmth/react-native-pager] whilst less mature of a library than snap carousel has much better performance results. With an average of 87fps on the realme6, and a better swiping experience (allows for swiping more than one card at a time).

Check that a scrollTo counterpart exists

@Redseb Redseb added the refactor A clean up / refactor of the code label Oct 21, 2020
@dibakar95
Copy link

dibakar95 commented Oct 30, 2020

Can I take this issue @Redseb

@Redseb
Copy link
Owner Author

Redseb commented Oct 30, 2020

Sure thing, that would be awesome. Let me know how it goes 👍🤞

Thanks for the help @dibakar95

@dibakar95
Copy link

@Redseb I am working on it. Please give me some time till this weekend.

@Redseb
Copy link
Owner Author

Redseb commented Nov 4, 2020

@dibakar95 That's fine, thank you for the progress update!

@dibakar95
Copy link

@Redseb The app always gets stuck in splashScreen in Android after a fresh install. I am facing this since I forked and Cloned the proejct. Any help would be appreciated.

@Redseb
Copy link
Owner Author

Redseb commented Nov 8, 2020

Hi, let me try to clone a fresh copy and see what the issue could be

@Redseb
Copy link
Owner Author

Redseb commented Nov 8, 2020

@dibakar95 I'm not having the same issues after a fresh clone. I once had to exit the app and open it again when the splash screen stayed for too long. Have you run both yarn and npm install? (Unfortunately, the project mixes both yarn and npm). I will add install instructions to the README

@Redseb
Copy link
Owner Author

Redseb commented Nov 12, 2020

Hi @dibakar95 have you managed to resolve the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor A clean up / refactor of the code
Projects
None yet
Development

No branches or pull requests

2 participants