Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nil results panic (maybe a document expiry issue?) #181

Open
Leila-Codes opened this issue Feb 1, 2023 · 2 comments
Open

nil results panic (maybe a document expiry issue?) #181

Leila-Codes opened this issue Feb 1, 2023 · 2 comments

Comments

@Leila-Codes
Copy link

Leila-Codes commented Feb 1, 2023

On occasion some document results may return a valid key but the document value is nil.

Unfortunately I don't yet have a specific repeatable case but the theory/suspicion is:

  1. JSON Document Added and Expiry is Set
  2. Search is run
  3. Document expires during query
  4. Document returned has valid key, but value is nil.

This is unhandled when casting inside loadDocument() which completely crashes reading of data.

Proposed solution is to handle cast errors appropriately. Will submit a new PR shortly with implementation.

@Leila-Codes Leila-Codes changed the title nil results panic nil results panic (maybe a document expiry issue?) Feb 1, 2023
@Leila-Codes
Copy link
Author

Added new PR #182

@danielpcox
Copy link

I have this problem too. In my case, the Redis connection is temporarily lost, and this results in a nil result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants