Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query re WITHPAYLOADS vs PAYLOADS #35

Open
mgravell opened this issue Aug 30, 2018 · 2 comments
Open

Query re WITHPAYLOADS vs PAYLOADS #35

mgravell opened this issue Aug 30, 2018 · 2 comments

Comments

@mgravell
Copy link

Heya; I was just reviewing deltas to look at what to update in NRediSearch, and I noticed that this commit moves from `WITHPAYLOADS" to "PAYLOADS"; however, the documentation here still says "WITHPAYLOADS". Can I query which is right? Or is this just used as a placeholder that the library detects and rewrites the args to suit?

@itamarhaber
Copy link
Contributor

Ouch :( Thanks @mgravell - looks like there's a discrepancy with the actual implementation: https://github.com/RedisLabsModules/RediSearch/blob/4a8dde6bd441aa936e8b0c20803854506bfa9234/src/search_request.c#L285

@davidparry
Copy link

davidparry commented Dec 4, 2018

i have a pull request that has this fix. PAYLOADS does not save the payload but WITHPAYLOADS on Query object works like a charm. #34
@itamarhaber i hope this gets past the difference seemed odd that they were different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants