Add pre commit

.github/workflows/pull_request.yml

@@ -14,7 +14,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python: [3.7.13, 3.8, 3.9]
+        python: [3.8, 3.9, 3.12]
     steps:
       - name: Checkout WrapanAPI
         uses: actions/checkout@v3
@@ -35,11 +35,5 @@ jobs:
           pip install --compile --no-cache-dir pycurl
           pip install -U -e .[test]
 
-      # coming soon
-      #- name: Pre Commit Checks
-      #  uses: pre-commit/[email protected]
-      #  with:
-      #    extra_args: --show-diff-on-failure
-
       - name: Run Unit Tests
         run: py.test tests/ -v --cov wrapanapi

.gitignore

@@ -3,11 +3,12 @@
 .pytest_cache/
 .coverage
 .venv*
+dist/
 .eggs
 *.egg-info
 .env/
 .idea/
 *.vars.json
 .tox/
 AUTHORS
-ChangeLog
+ChangeLog

.pre-commit-config.yaml

@@ -0,0 +1,33 @@
+ci:
+  autofix_prs: false
+repos:
+  - repo: https://github.com/asottile/reorder_python_imports
+    rev: v3.9.0
+    hooks:
+      - id: reorder-python-imports
+        args:
+          - --application-directories=.:wrapanapi
+  - repo: https://github.com/psf/black
+    rev: 23.3.0
+    hooks:
+      - id: black
+        args: [--safe, --quiet, --line-length, "100"]
+        require_serial: true
+  - repo: https://github.com/PyCQA/flake8
+    rev: 6.0.0
+    hooks:
+      - id: flake8
+        args:
+          - --max-line-length=100
+          - --ignore=W503,E203
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v4.4.0
+    hooks:
+      - id: trailing-whitespace
+      - id: end-of-file-fixer
+      - id: debug-statements
+  - repo: https://github.com/asottile/pyupgrade
+    rev: v3.3.2
+    hooks:
+      - id: pyupgrade
+        args: [--py3-plus, --py38-plus]

LICENSE

@@ -16,4 +16,4 @@ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-THE SOFTWARE.
+THE SOFTWARE.

README.rst

@@ -76,7 +76,7 @@ Each management system is invoked usually with a hostname and some credentials
 .. code-block:: python
 
   from wrapanapi.virtualcenter import VMWareSystem
-  
+
   system = VMWareSystem(hostname='10.0.0.0', username="root", password="password")
   system.list_vm()
 
@@ -90,15 +90,15 @@ it doesn't support. This behaviour may change in the future as more and more div
   from base import WrapanapiAPIBase
 
   class RHEVMSystem(WrapanapiAPIBase):
-  
+
     _stats_available = {
       'num_vm': lambda self: self.api.get_summary().get_vms().total,
       'num_host': lambda self: len(self.list_host()),
       'num_cluster': lambda self: len(self.list_cluster()),
       'num_template': lambda self: len(self.list_template()),
       'num_datastore': lambda self: len(self.list_datastore()),
     }
-  
+
     def __init__(self, hostname, username, password, **kwargs):
       super(RHEVMSystem, self).__init__(kwargs)
 
@@ -116,5 +116,5 @@ This module was originally developed for assisting in the ManageIQ testing team.
 
 Contributing
 ------------
-The guidelines to follow for this project can be found in the 
+The guidelines to follow for this project can be found in the
 cfme `dev_guide <http://cfme-tests.readthedocs.org/guides/dev_guide.html>`_.

pyproject.toml

@@ -75,6 +75,9 @@ dependencies = [
 ]
 
 [project.optional-dependencies]
+dev = [
+  "pre-commit",
+]
 test = [
     "mock",
     "pytest",

tests/__init__.py

@@ -1 +0,0 @@
-# -*- coding: utf-8 -*-

tests/resources/hawkular/inventory/feeds/328c17e1-c97f-4583-89d8-73feb0cf47f6/resources/WildfyServerOne~%2Fsubsystem%3Ddatasources%2Fdata-source%3DExampleDSMWTest/data.json

@@ -9,4 +9,4 @@
     "Password" : "sa"
   },
   "name" : "configuration"
-}
+}

tests/resources/hawkular/inventory/feeds/328c17e1-c97f-4583-89d8-73feb0cf47f6/resources/WildfyServerOne~%2Fsubsystem%3Ddatasources%2Fdata-source%3DExampleXADSMWTest/data.json

@@ -9,4 +9,4 @@
     "Password" : "sa"
   },
   "name" : "configuration"
-}
+}

tests/resources/hawkular/inventory/feeds/328c17e1-c97f-4583-89d8-73feb0cf47f6/resources/WildfyServerOne~~/WildfyServerOne~%2Fsubsystem%3Ddatasources%2Fdata-source%3DExampleDS/data.json

@@ -9,4 +9,4 @@
     "Password" : "sa"
   },
   "name" : "configuration"
-}
+}

tests/resources/hawkular/inventory/feeds/328c17e1-c97f-4583-89d8-73feb0cf47f6/resources/WildfyServerOne~~/WildfyServerOne~%2Fsubsystem%3Ddatasources%2Fdata-source%3DExampleXADS/data.json

@@ -9,4 +9,4 @@
     "Password" : "sa"
   },
   "name" : "configuration"
-}
+}

tests/resources/hawkular/inventory/feeds/5ea2d44a-6b07-424b-b54e-0b4c798d1353/resourceTypes.json

@@ -90,4 +90,3 @@
         "id": "Hawkular WildFly Agent"
     }
 ]
-

tests/resources/hawkular/inventory/feeds/5ea2d44a-6b07-424b-b54e-0b4c798d1353/resources/Local~%2Fsubsystem%3Ddatasources%2Fdata-source%3DExampleDSMWTest/data.json

@@ -9,4 +9,4 @@
     "Password" : "sa"
   },
   "name" : "configuration"
-}
+}

tests/resources/hawkular/inventory/feeds/5ea2d44a-6b07-424b-b54e-0b4c798d1353/resources/Local~%2Fsubsystem%3Ddatasources%2Fdata-source%3DExampleXADSMWTest/data.json

@@ -9,4 +9,4 @@
     "Password" : "sa"
   },
   "name" : "configuration"
-}
+}

tests/resources/hawkular/inventory/feeds/5ea2d44a-6b07-424b-b54e-0b4c798d1353/resources/Local~%2Fsubsystem%3Ddatasources%2Fdata-source%3DKeycloakDSMWTest/data.json

@@ -9,4 +9,4 @@
     "Password" : "sa"
   },
   "name" : "configuration"
-}
+}

tests/resources/hawkular/inventory/feeds/5ea2d44a-6b07-424b-b54e-0b4c798d1353/resources/Local~~/Local~%2Fsubsystem%3Ddatasources%2Fdata-source%3DExampleDS/data.json

@@ -9,4 +9,4 @@
     "Password" : "sa"
   },
   "name" : "configuration"
-}
+}

tests/resources/hawkular/inventory/feeds/5ea2d44a-6b07-424b-b54e-0b4c798d1353/resources/Local~~/Local~%2Fsubsystem%3Ddatasources%2Fdata-source%3DExampleXADS/data.json

@@ -9,4 +9,4 @@
     "Password" : "sa"
   },
   "name" : "configuration"
-}
+}

tests/resources/hawkular/inventory/feeds/5ea2d44a-6b07-424b-b54e-0b4c798d1353/resources/Local~~/Local~%2Fsubsystem%3Ddatasources%2Fdata-source%3DKeycloakDS/data.json

@@ -9,4 +9,4 @@
     "Password" : "sa"
   },
   "name" : "configuration"
-}
+}

tests/resources/hawkular/inventory/feeds/c22fb9d6-0ffc-42cd-bf5b-e1d046398fe5/resources/WildfyServerTwo~%2Fsubsystem%3Ddatasources%2Fdata-source%3DExampleDSMWTest/data.json

@@ -9,4 +9,4 @@
     "Password" : "sa"
   },
   "name" : "configuration"
-}
+}

tests/resources/hawkular/inventory/feeds/c22fb9d6-0ffc-42cd-bf5b-e1d046398fe5/resources/WildfyServerTwo~%2Fsubsystem%3Ddatasources%2Fdata-source%3DExampleXADSMWTest/data.json

@@ -9,4 +9,4 @@
     "Password" : "sa"
   },
   "name" : "configuration"
-}
+}

tests/resources/hawkular/inventory/feeds/c22fb9d6-0ffc-42cd-bf5b-e1d046398fe5/resources/WildfyServerTwo~~/WildfyServerTwo~%2Fsubsystem%3Ddatasources%2Fdata-source%3DExampleDS/data.json

@@ -9,4 +9,4 @@
     "Password" : "sa"
   },
   "name" : "configuration"
-}
+}

tests/resources/hawkular/inventory/feeds/c22fb9d6-0ffc-42cd-bf5b-e1d046398fe5/resources/WildfyServerTwo~~/WildfyServerTwo~%2Fsubsystem%3Ddatasources%2Fdata-source%3DExampleXADS/data.json

@@ -9,4 +9,4 @@
     "Password" : "sa"
   },
   "name" : "configuration"
-}
+}

tests/resources/hawkular/inventory/feeds/master.eap7%20domain/resources/Host Controller/data.json

@@ -5,7 +5,7 @@
         "Server State": "running",
         "Product Name": "WildFly Full",
         "Local Host Name": "skondkar-hawkular.bc.jonqe.lab.eng.bos.redhat.com"
-        
+
     },
     "name": "configuration"
 }

tests/resources/hawkular/inventory/status.json

@@ -3,4 +3,4 @@
     "Built-From-Git-SHA1": "3c8ac6648aa0ec33643ae1b98faadc475d2c6f02",
     "Inventory-Implementation": "org.hawkular.inventory.impl.tinkerpop.TinkerpopInventory",
     "Initialized": "true"
-}
+}

tests/resources/hawkular/metrics/status.json

@@ -3,4 +3,4 @@
 	"Implementation-Version":"0.26.0.Final",
 	"Built-From-Git-SHA1":"fe3ef3ccc36a0c85bcdbf3e96aae8d36a636f7f2",
 	"Cassandra":"up"
-}
+}