wait_for_condition: use sampler, not watcher #1248

myakove · 2023-07-16T15:58:25Z

Short description:

Use TimeoutSampler to wait_for_condition

More details:

When using watcher() if there is a network issue the wait will break

redhat-qe-bot · 2023-07-16T15:58:28Z

Report bugs in Issues

The following are automatically added:

Add reviewers from OWNER file (in the root of the repository) under reviewers section.
Set PR size label.
New issue is created for the PR. (Closed when PR is merged/closed)
Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
verified label removed on each new commit push.
To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
- Support only merged PRs
To re-run tox comment /retest tox in the PR.
To re-run build-container command /retest build-container in the PR.
To re-run python-module-install command /retest python-module-install in the PR.
To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
To add a label by comment use /<label name>, to remove, use /<label name> cancel

Supported labels

hold
verified
wip
lgtm
approve
target-branch-

sonarcloud · 2023-07-16T16:02:36Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

myakove · 2023-07-16T18:02:33Z

/verified

myakove · 2023-07-16T18:02:59Z

/cherry-pick v4.14

* add v4.14 to renovate.json * Exapnd MachineConfigPool for creation (#1204) * Exapnd MachineConfigPool for creation * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * ICSP: set repository_digest_mirrors to None (#1231) * Add close-stale-issues workflow * [pre-commit.ci] pre-commit autoupdate (#1239) updates: - [github.com/hadialqattan/pycln: v2.1.3 → v2.1.5](hadialqattan/pycln@v2.1.3...v2.1.5) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * rmemove pre-commit-hooks * remove ruff from pre-commit * Update OWNERS (#1241) * adding omrirh to owners * Update OWNERS Co-authored-by: oharan2 <[email protected]> --------- Co-authored-by: Meni Yakove <[email protected]> Co-authored-by: oharan2 <[email protected]> * StorageClass - add support for resource creation (#1246) * Update StorageClass class * fix per review * fix per review * wait_for_condition: use sampler, not watcher (#1248) * wait_for_condition: use sampler, not watcher * wait_for_condition: use sampler, not watcher * [pre-commit.ci] pre-commit autoupdate (#1245) updates: - [github.com/PyCQA/autoflake: v2.1.1 → v2.2.0](PyCQA/autoflake@v2.1.1...v2.2.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * disable stale.yml * Update close-stale-issues.yml * [pre-commit.ci] pre-commit autoupdate (#1252) updates: - [github.com/psf/black: 23.3.0 → 23.7.0](psf/black@23.3.0...23.7.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> --------- Co-authored-by: Yossi Segev <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Omri Bar Haim <[email protected]> Co-authored-by: oharan2 <[email protected]> Co-authored-by: dalia-frank <[email protected]> Co-authored-by: Ruth Netser <[email protected]>

* Release 4.14.0 * ICSP: set repository_digest_mirrors to None (#1231) (#1233) Co-authored-by: Meni Yakove <[email protected]> * Release 4.14.1 * wait_for_condition: use sampler, not watcher (#1250) * Release 4.14.2 * Sync from main (#1253) * add v4.14 to renovate.json * Exapnd MachineConfigPool for creation (#1204) * Exapnd MachineConfigPool for creation * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * ICSP: set repository_digest_mirrors to None (#1231) * Add close-stale-issues workflow * [pre-commit.ci] pre-commit autoupdate (#1239) updates: - [github.com/hadialqattan/pycln: v2.1.3 → v2.1.5](hadialqattan/pycln@v2.1.3...v2.1.5) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * rmemove pre-commit-hooks * remove ruff from pre-commit * Update OWNERS (#1241) * adding omrirh to owners * Update OWNERS Co-authored-by: oharan2 <[email protected]> --------- Co-authored-by: Meni Yakove <[email protected]> Co-authored-by: oharan2 <[email protected]> * StorageClass - add support for resource creation (#1246) * Update StorageClass class * fix per review * fix per review * wait_for_condition: use sampler, not watcher (#1248) * wait_for_condition: use sampler, not watcher * wait_for_condition: use sampler, not watcher * [pre-commit.ci] pre-commit autoupdate (#1245) updates: - [github.com/PyCQA/autoflake: v2.1.1 → v2.2.0](PyCQA/autoflake@v2.1.1...v2.2.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * disable stale.yml * Update close-stale-issues.yml * [pre-commit.ci] pre-commit autoupdate (#1252) updates: - [github.com/psf/black: 23.3.0 → 23.7.0](psf/black@23.3.0...23.7.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> --------- Co-authored-by: Yossi Segev <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Omri Bar Haim <[email protected]> Co-authored-by: oharan2 <[email protected]> Co-authored-by: dalia-frank <[email protected]> Co-authored-by: Ruth Netser <[email protected]> * Release 4.14.3 * Add kubevirt market to test_vm (#1257) Co-authored-by: RedHatQE <None> --------- Co-authored-by: redhat-qe-bot <[email protected]> Co-authored-by: Yossi Segev <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Omri Bar Haim <[email protected]> Co-authored-by: oharan2 <[email protected]> Co-authored-by: dalia-frank <[email protected]> Co-authored-by: Ruth Netser <[email protected]>

wait_for_condition: use sampler, not watcher

df1d36e

redhat-qe-bot added size/XS branch-main labels Jul 16, 2023

redhat-qe-bot assigned myakove Jul 16, 2023

redhat-qe-bot requested review from rnetser, omrirh and oharan2 July 16, 2023 15:58

redhat-qe-bot mentioned this pull request Jul 16, 2023

wait_for_condition: use sampler, not watcher - 1248 #1249

Closed

wait_for_condition: use sampler, not watcher

049ac05

rnetser approved these changes Jul 16, 2023

View reviewed changes

redhat-qe-bot added the Approved-by-rnetser label Jul 16, 2023

redhat-qe-bot added verified can-be-merged labels Jul 16, 2023

myakove merged commit 04f1ebe into main Jul 16, 2023
7 checks passed

myakove deleted the wait_for_condition-use-sampler branch July 16, 2023 18:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

wait_for_condition: use sampler, not watcher #1248

wait_for_condition: use sampler, not watcher #1248

myakove commented Jul 16, 2023

redhat-qe-bot commented Jul 16, 2023

sonarcloud bot commented Jul 16, 2023

myakove commented Jul 16, 2023

myakove commented Jul 16, 2023

wait_for_condition: use sampler, not watcher #1248

wait_for_condition: use sampler, not watcher #1248

Conversation

myakove commented Jul 16, 2023

Short description:

More details:

redhat-qe-bot commented Jul 16, 2023

sonarcloud bot commented Jul 16, 2023

myakove commented Jul 16, 2023

myakove commented Jul 16, 2023