refactor: remove unleash-proxy dependency (HMS-4929) #2725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
Moved validation function to config package. Removed check for ephemeral environment as there will be instance of unleash with flags off. FeatureFlagsService was never actually used. The unleash secrets were passed, but always overriden by clowder. CheckFeature is now returning early when unleash is not configured.
unleash-proxy is unmaintained and was not really used.
ezr-ondrej
force-pushed
the
remove-unleash-proxy
branch
from
4ef867a
to
a33bd33
Compare
ezr-ondrej
changed the title
ezr-ondrej
changed the title
|
/retest |
lzap
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved validation function to
configpackage.Removed check for ephemeral environment as there will be instance of unleash with flags off, so no need to return for ephemeral.
FeatureFlagsServiceconfig was never actually used.The unleash secrets were passed, but always overriden by clowder.
CheckFeature is now returning early when unleash is not configured.
Fixes: HMS-4929