Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev to Main sync #2172

Merged
merged 2 commits into from
Sep 21, 2024
Merged

Dev to Main sync #2172

merged 2 commits into from
Sep 21, 2024

Conversation

fakhruddinkw
Copy link
Contributor

@fakhruddinkw fakhruddinkw commented Sep 20, 2024


Date: 20-09-2024

Developer Name: Fakhruddin KW


Issue Ticket Number

#2024 Adding FF to PUT /discord-action/group-idle-7d

Description

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1

Test Coverage

Screenshot 1

Additional Notes

* added condition to prevent mavens being added to idle,idle7d

* edited test for group-idle-7d and added test for group-idle

* resolving build error

* resolving test errors

* fixing tests

* fixed the tests

* added model tests

* added line break

* resolving Tejas's comments

* fixed model function

* added feature flag

* adding feature flag

* edited tests

* fixing unit

* added FF

---------

Co-authored-by: Amit Prakash <[email protected]>
@fakhruddinkw fakhruddinkw changed the title Adding FF to Maven getting listed in idle,idle-7d+ (#2171) Dev to Main sync Sep 20, 2024
@fakhruddinkw fakhruddinkw reopened this Sep 21, 2024
@iamitprakash iamitprakash merged commit 59d4720 into main Sep 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants