Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dev feature flag from GET /github/callback API #2146

Closed
5 of 10 tasks
samarpan1738 opened this issue Sep 10, 2024 · 1 comment
Closed
5 of 10 tasks

Remove dev feature flag from GET /github/callback API #2146

samarpan1738 opened this issue Sep 10, 2024 · 1 comment

Comments

@samarpan1738
Copy link
Contributor

Issue Description

This API has been live on prod for a long time but the feature flag has not been removed.
Please verify if this needs to be removed or not

Reason for adding dev FF

  1. dev FF is being checked in the redirect url
  2. If dev=true , do not redirect . PR link

Usages in other repos
None

This is a subtask of #2075

Expected Behavior

Current Behavior

Screenshots

NA

Reproducibility

  • This issue is reproducible
  • This issue is not reproducible

Steps to Reproduce

NA

Severity/Priority

  • Critical
  • High
  • Medium
  • Low

Additional Information

Checklist

  • I have read and followed the project's code of conduct.
  • I have searched for similar issues before creating this one.
  • I have provided all the necessary information to understand and reproduce the issue.
  • I am willing to contribute to the resolution of this issue.
@samarpan1738
Copy link
Contributor Author

As discussed with @prakashchoudhary07 we aren't sure about the exact reason for handling the dev FF here.
Hence not removing this for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samarpan1738