[WIP] Refactor using curry_flip from Expression library #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Propose some test cleanup (more readable) Propose typing overload for map_ Propose defining a UnaryOperator type
Propose MonoTypeOperator type Propose documentation draft for curry flip
Hint on contributing, checks to run
|
@dbrattli If I'm going to make changes related to this like add curry_flip on some operators, maybe amending some types or adding overrides, would you prefer if I branch out and PR into this branch or push changes direct to the branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP branch for refactoring RxPY to use
curry_flipfrom the Expression library. This will remove a lot of boilerplate code and make the operator code more readable (no nested functions).