This repository has been archived by the owner on Nov 20, 2023. It is now read-only.
feat: add Shizuku installation support
#83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aunali321
changed the title
Shizuku installation supportShizuku installation support (WIP)
Aunali321
changed the title
Shizuku installation support (WIP)Shizuku installation support
CnC-Robert
suggested changes
Aug 15, 2023
app/src/main/java/app/revanced/manager/ui/viewmodel/InstallerViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/app/revanced/manager/ui/component/ShizukuCard.kt
Outdated
Show resolved
Hide resolved
Axelen123
reviewed
Aug 15, 2023
app/src/main/java/app/revanced/manager/service/ShizkuService.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # app/src/main/java/app/revanced/manager/ui/screen/InstalledAppsScreen.kt # app/src/main/java/app/revanced/manager/ui/viewmodel/InstallerViewModel.kt
Axelen123
suggested changes
Aug 23, 2023
| }) | ||
|
|
||
| val installer by prefs.defaultInstaller.getAsState() | ||
| GroupHeader(stringResource(R.string.installer)) |
There was a problem hiding this comment.
The formatting in this file is weird
There was a problem hiding this comment.
Default android studio formatting
There was a problem hiding this comment.
Keep the custom line breaks next time. The rest of the codebase also has them.
Here is a version of the file with the line breaks restored: https://gist.github.com/Axelen123/834748677989c88531cc01e7194cab2e
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Shizuku installer