Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a toggle to the Hide launch icon menu #39

Conversation

rufusin
Copy link

@rufusin rufusin commented Apr 3, 2024

No description provided.

@oSumAtrIX
Copy link
Member

Thanks for the PR but it does not follow the contribution instructions in the README

@oSumAtrIX oSumAtrIX closed this Apr 3, 2024
@rufusin rufusin deleted the feat-Add-a-toggle-to-the-`Hide-launch-icon`-menu branch April 3, 2024 07:35
@kazimmt
Copy link

kazimmt commented May 31, 2024

Maybe create the same PR in https://github.com/microg/GmsCore

If they merge it, we will have it in ReVanced GmsCore too

@ILoveOpenSourceApplications

Maybe create the same PR in https://github.com/microg/GmsCore

If they merge it, we will have it in ReVanced GmsCore too.

Well after seeing this and having not seen @rufusin around, I took matters into my own hands and opened microg#2462. Hoping there'll be some minute changes as the code worked pretty well. But I was wrong and some of the recent review requests are outside of my understanding. So if anyone here is knowledgeable in this area and have some free time and want to see this implemented, do feel to help me in whatever way you can.

@kazimmt
Copy link

kazimmt commented Oct 3, 2024

@YT-Advanced maybe you can help him

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants