Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quality of Life][3.1.1]: Popup reports file conflicts but one of them is disabled (false negative) #245

Open
1 task done
techyCoder81 opened this issue Mar 25, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@techyCoder81
Copy link
Contributor

techyCoder81 commented Mar 25, 2022

Have you read the disclaimer before proceeding?

  • I have read the disclaimer.

Explain what could get improvements.

It would be an improvement to not have a popup appear stating that there will be file conflicts, when one of the two folders is disabled.

How could we make this better?

When a mod folder is disabled, it should not proc a "file conflicts!" popup, because this is a false negative. Currently, as far as I can tell, the actual behavior is correct when you have conflicts but one of them is disabled. The correct files are loaded (and the correct plugin is chainloaded, if relevant). The only issue is the false negative popup telling you that you have conflicts.

Update: @blu-dev suggests this may cause issues with patch files also, which may need to be addressed - "patch files will still apply even if host mod has conflicts"

@techyCoder81 techyCoder81 added the enhancement New feature or request label Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant