Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Hash arrays" work lacks a specific testbench #247

Open
thejayps opened this issue Jun 16, 2023 · 4 comments
Open

"Hash arrays" work lacks a specific testbench #247

thejayps opened this issue Jun 16, 2023 · 4 comments
Labels
essential Will cause failure to meet customer requirements. Assign resources. review-raise Issue raised from proc.review.edit

Comments

@thejayps
Copy link
Contributor

#230 has no testbench.

We discussed (@thejayps, @rptb1 and @UNAA008) during the preparation of the pull request that the testbench would be difficult to write, and decided to defer it until some time after 1.118. The code has been in use by Configura for some time who have reported no issues so far

@thejayps thejayps added review-raise Issue raised from proc.review.edit essential Will cause failure to meet customer requirements. Assign resources. labels Jun 19, 2023
@thejayps
Copy link
Contributor Author

See also #239 - @UNAA008 asked what is meant by a "specific testbench"

@rptb1
Copy link
Member

rptb1 commented Jun 19, 2023

I'm also wondering where the word "testbench" came from and whether it means anything specific. I think @thejayps introduced it.

@thejayps
Copy link
Contributor Author

By "specific", I meant that at the time of writing, I hadn't (and still haven't) proved that there wasn't a test or tests somewhere that exercises this hash arrays feature, but that there doesn't seem to be a test that is specifically designed to verify that hash arrays meets requirements.

In my mind "Testbench" is no different in meaning to "test". It might be an engineering/computer science convention thing. In the former it's more likely to be used by people who also connect lots of unusual things up on benches as well as write software to drive it all. I'm keen to tidy up the language around tests in places where it's confusing so we can discourage future bench suffixes if desired :)

@rptb1
Copy link
Member

rptb1 commented Jun 20, 2023

The split between MMQA (see also #116 ) and other tests definitely needs tidying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
essential Will cause failure to meet customer requirements. Assign resources. review-raise Issue raised from proc.review.edit
Projects
None yet
Development

No branches or pull requests

2 participants