Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Singleton not thread safe #17

Open
iamareebjamal opened this issue Dec 28, 2017 · 2 comments
Open

Singleton not thread safe #17

iamareebjamal opened this issue Dec 28, 2017 · 2 comments

Comments

@iamareebjamal
Copy link

The singleton pattern is prone to synchronization errors and is not thread-safe. If multiple thread mutate the state of Push Raven, it will lead to an inconsistent state. The library is really great and I would like to contribute in it after some discussion over design patterns are done

I think we can achieve simpler syntax with production level design with minimal impact on current API

@Raudius
Copy link
Owner

Raudius commented Dec 29, 2017

I am open to any suggestions, in fact the singleton implementation came about after issue #2

@iamareebjamal
Copy link
Author

Sure. I will add the proposed changes here soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants