Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add can terminator #62

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Conversation

AsiiaPine
Copy link
Collaborator

This PR adds parameter which controls CAN_TERMINATOR for v3 of mini node with stm32g0.

Firmware image size difference

  • dronecan_v2: 40796 -> 40840 (+44)
  • dronecan_v3: 49916 -> 50424 (+508)
  • cyphal_v2: 43480 -> 43524 (+44)
  • cyphal_v3: 54708 -> 54752 (+44)

Test coverage

In SITL the feature is not implemented, for v3 works

@AsiiaPine AsiiaPine marked this pull request as ready for review September 5, 2024 12:41
@AsiiaPine AsiiaPine force-pushed the pr-can-terminator branch 3 times, most recently from 4310f32 to 1e43c46 Compare September 5, 2024 12:56
@PonomarevDA PonomarevDA added the enhancement New feature or request label Sep 6, 2024
Copy link

sonarcloud bot commented Sep 9, 2024

@PonomarevDA PonomarevDA changed the title Pr can terminator Add can terminator Sep 9, 2024
@PonomarevDA PonomarevDA merged commit 4828b34 into RaccoonlabDev:main Sep 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants