Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMDGPU] OCL12 Adapter: avoid processing of special C++ functions #50

Open
wants to merge 1 commit into
base: amd-common
Choose a base branch
from
Open

[AMDGPU] OCL12 Adapter: avoid processing of special C++ functions #50

wants to merge 1 commit into from

Conversation

vpykhtin
Copy link

This avoids processing of functions like _ZdlPv ( void operator delete(void *)) by the OCL12 Adapter pass which fixes failure within HCC compiler. Special C++ functions has predefined names which doesn't start with namelength after _Z prefix. So this fix:

  1. Checks whether _Z is followed by the namelength.
  2. Remove redundant Value::getName calls as they are not that cheap to be called with copy/paste fashion.

@kzhuravl
Copy link

Can you add a test case?

@BorisI BorisI requested a review from nhaustov May 16, 2017 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants