Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements #3514

Merged
merged 5 commits into from
Jun 10, 2024
Merged

Update requirements #3514

merged 5 commits into from
Jun 10, 2024

Conversation

neon60
Copy link
Contributor

@neon60 neon60 commented Jun 6, 2024

Update requirements, the 6.1.2 was already updated.

@neon60 neon60 changed the base branch from develop to docs/develop June 6, 2024 16:58
@neon60 neon60 requested review from samjwu and yhuiYH and removed request for mangupta, gandryey and rakesroy June 6, 2024 16:58
Copy link
Member

@samjwu samjwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

ideally I think we want to modify the .github/dependabot.yml to target this branch to have these PRs done by the bot
https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#target-branch

@neon60
Copy link
Contributor Author

neon60 commented Jun 7, 2024

looks good

ideally I think we want to modify the .github/dependabot.yml to target this branch to have these PRs done by the bot https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#target-branch

Good idea, checking what I need to do.

@neon60
Copy link
Contributor Author

neon60 commented Jun 8, 2024

looks good
ideally I think we want to modify the .github/dependabot.yml to target this branch to have these PRs done by the bot https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#target-branch

Good idea, checking what I need to do.

Update the target branch.

@neon60
Copy link
Contributor Author

neon60 commented Jun 10, 2024

@samjwu Could you merge this in? Could I merge this in?

@samjwu samjwu merged commit 79ff964 into docs/develop Jun 10, 2024
3 checks passed
@samjwu
Copy link
Member

samjwu commented Jun 10, 2024

Feel free to merge it in when it's approved

I merged it in this time

@neon60 neon60 deleted the update_requirements branch June 10, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants