Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linting.yml #3496

Merged
merged 1 commit into from
May 28, 2024
Merged

Add linting.yml #3496

merged 1 commit into from
May 28, 2024

Conversation

neon60
Copy link
Contributor

@neon60 neon60 commented May 23, 2024 •
edited
Loading

  • The following PR has to merged in first: Update spellcheck yml rocm-docs-core#794
  • Added spellcheck to docs folder md and rst files
  • Added markdown file check
  • Fixed the makrdown styling inconsistency
  • Fixed abbreviation usage inconsistency
  • Fixed typos

@neon60 neon60 changed the base branch from develop to docs/develop May 23, 2024 11:35
@neon60 neon60 changed the title Add grammar check Add linting.yml May 23, 2024
@neon60 neon60 force-pushed the add_grammar_check branch 3 times, most recently from d44e26d to 3dc3cfd Compare May 24, 2024 06:31
@neon60 neon60 force-pushed the add_grammar_check branch 8 times, most recently from 29eba75 to 39e7922 Compare May 26, 2024 07:43
yhuiYH
yhuiYH approved these changes May 27, 2024
View reviewed changes
Copy link

@yhuiYH yhuiYH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, great effort here to fix all the typos. I like this. Let's merge this thru gerrit, and back out to GitHub.

@neon60
Add linting and spellcheck
4d2936d 
- Markdown fixes
- Fix spellcheck
- Clean up
- Supress etoc warning
- Remove folder before clone if it's exist
- Change liniting.yml to use develop
@neon60
Copy link
Contributor Author

neon60 commented May 28, 2024 •
edited
Loading

Nice, great effort here to fix all the typos. I like this. Let's merge this thru gerrit, and back out to GitHub.

Thanks. Squashed the commits, merging to docs/develop. It will reach amd-staging soon.

@neon60 neon60 merged commit fb688c8 into docs/develop May 28, 2024
3 checks passed
@neon60 neon60 deleted the add_grammar_check branch June 10, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhuiYH yhuiYH yhuiYH approved these changes

@gandryey gandryey Awaiting requested review from gandryey gandryey is a code owner

@mangupta mangupta Awaiting requested review from mangupta mangupta is a code owner

@rakesroy rakesroy Awaiting requested review from rakesroy rakesroy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neon60 @yhuiYH