Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Why is the default discount factor 0.999 for PPO and 0.99 for DQN? #40

Open
4 tasks done
roger-creus opened this issue Nov 23, 2023 · 1 comment
Open
4 tasks done
Labels
question Further information is requested

Comments

@roger-creus
Copy link
Collaborator

❓ Question

I would think 0.99 is the most widely used default value, so I suggest using that for PPO as well.

Checklist

  • I have checked that there is no similar issue in the repo
  • I have read the documentation
  • If code there is, it is minimal and working
  • If code there is, it is formatted using the markdown code blocks for both code and stack traces.
@roger-creus roger-creus added the question Further information is requested label Nov 23, 2023
@yuanmingqi
Copy link
Contributor

0.999 is used for the Procgen games.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants