Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/tinydtls: don't require ztimer64 #19352

Merged
merged 1 commit into from
Mar 6, 2023
Merged

pkg/tinydtls: don't require ztimer64 #19352

merged 1 commit into from
Mar 6, 2023

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Mar 6, 2023 •
edited
Loading

Contribution description

The RIOT integration makes no use of ztimer64, so drop it.

Testing procedure

Code still compiles, ztimer64 is not used.

Issues/PRs references

@benpicco
pkg/tinydtls: don't require ztimer64
8af8230 
The RIOT integration makes no use of ztimer64, so drop it.
@github-actions github-actions bot added the Area: pkg Area: External package ports label Mar 6, 2023
@benpicco benpicco added Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 6, 2023
@kfessel
Copy link
Contributor

kfessel commented Mar 6, 2023 •
edited
Loading

seems like our followup to eclipse/tinydtls#123 being merged upstream got lost somehow

see #17564

kfessel
kfessel approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@kfessel kfessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

match upstream

@riot-ci
Copy link

riot-ci commented Mar 6, 2023

Murdock results

✔️ PASSED

8af8230 pkg/tinydtls: don't require ztimer64

Success Failures Total Runtime
6919 0 6919 12m:58s

Artifacts

@benpicco
Copy link
Contributor Author

benpicco commented Mar 6, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Mar 6, 2023

Build succeeded:

@bors bors bot merged commit 777857a into RIOT-OS:master Mar 6, 2023
@benpicco benpicco deleted the pkg/tinydtls-ztimer_msec branch March 6, 2023 22:34
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.04 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfessel kfessel kfessel approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@kaspar030 kaspar030 Awaiting requested review from kaspar030

Assignees
No one assigned
Labels
Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2023.04
Development

Successfully merging this pull request may close these issues.
4 participants
@benpicco @kfessel @riot-ci @MrKevinWeiss