Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/test building default #23

Merged
merged 2 commits into from
May 30, 2024
Merged

Conversation

SebastianSvanland
Copy link
Contributor

When building isoObject with colcon build, BUILD_TESTING is "ON" by default which makes compiler look for SWIG (fails builds if SWIG isn't installed and you don't want to build it).

Removed compulsory SWIG dependency when building tests and also added an "OFF" default to the BUILD_TESTING flag for non maintainers.

Copy link
Collaborator

@victorjarlow victorjarlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianSvanland SebastianSvanland merged commit 8168801 into master May 30, 2024
1 check passed
@SebastianSvanland SebastianSvanland deleted the fix/test_building_default branch May 30, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants